fix: avoid row-gap following gap with CSS variable #9634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
changed the title
vursen
changed the title
vursen
changed the title
web-padawan
reviewed
Jul 3, 2025
custom-rules/stylelint/no-shorthand-with-unresolved-longhand.js
Outdated
Show resolved
Hide resolved
|
web-padawan
approved these changes
Jul 4, 2025
vursen
deleted the
improve-no-shorthand-with-unresolved-longhand-stylelint
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR improves the
no-shorthand-with-unresolved-longhandstylelint rule to catch more cases where a shorthand property uses a CSS variable and is followed by one of its longhand properties, e.g:These cases are problematic because the browser cannot correctly serialize them when
cssTextis accessed on a CSSStyleSheet. As a result, these properties are serialized with invalid, empty values.Finding from #9594
Type of change