-
Notifications
You must be signed in to change notification settings - Fork 87
refactor!: update to Quill v2, drop outdated Firefox patch #9007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@web-padawan Not a bug, but by design how some Quill internal tags were removed to clean the html value: #6434 So I think change is valid as Quill has now method to get html value instead of our own hack. |
a4ebd07
to
d025045
Compare
I'm talking about a different logic added in #6651 and #6652 as a fix for vaadin/flow-components#5533. web-components/packages/rich-text-editor/test/basic.test.js Lines 318 to 323 in 76a7f05
UPD: this was introduced in slab/quill#4502 which landed in v2.0.3 patch release and a number of users were upset and had to pin to v2.0.2 - see discussion at slab/quill#4502 (comment) and this issue: slab/quill#4509 |
955c282
to
a93b758
Compare
a93b758
to
59f4891
Compare
Updated the Quill fork to apply the workaround from slab/quill#4509 (comment), see vaadin/quill@76a4568. |
|
Description
Fixes #1680
WIP, all tests passed locally but this still needs some manual testing especially for
htmlValue
logic.getComposedRanges()
API available since Safari 17+htmlValue
logic to usegetSemanticHTML()
API instead ofinnerHTML
spellcheck="false"
on<pre>
tag<code>
tags e.g. when usingdangerouslySetHtmlValue('<pre><code>123</code></pre>');
htmlValue
contains
instead of regular whitespacegetSemanticHTML
is broken slab/quill#4509li[data-list='bullet'] > .ql-ui::before
withcontent: '\\2022';
for bullets - replaced those with nativelist-style-type
for now (didn't manage to get custom bullets use correct vertical alignment).Type of change