refactor!: use CSS gap for row and column spacing #8638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
changed the title
1 task
vursen
force-pushed
the
refactor-form-layout-to-use-CSS-gaps
branch
2 times, most recently
from
fec1f8a to
fd597be
Compare
vursen
force-pushed
the
refactor-form-layout-to-use-CSS-gaps
branch
from
fd597be to
2c660a6
Compare
vursen
changed the title
vursen
force-pushed
the
refactor-form-layout-to-use-CSS-gaps
branch
from
efe89ef to
062adbe
Compare
vursen
commented
Feb 5, 2025
| @@ -6,7 +6,7 @@ registerStyles( | |||
| css` | |||
| :host { | |||
| --vaadin-form-layout-column-spacing: var(--lumo-space-l); | |||
| --vaadin-form-layout-row-spacing: 0; | |||
| --vaadin-form-item-row-spacing: 0; | |||
There was a problem hiding this comment.
This is needed to override the default 1em value because it's now a part of the var expression: https://github.com/vaadin/web-components/pull/8638/files#diff-6ad2d1beab300f671707a82e473d6377e11eb67525696d17cc7ceb3097b6bd3fR54
vursen
commented
Feb 8, 2025
vursen
commented
Feb 8, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors the FormLayout component to use CSS gap for defining spacing between rows and columns. The row gap is controlled by
--vaadin-form-layout-row-spacing, which defaults to 0. The deprecated--vaadin-form-item-row-spacingstill applies as long as--vaadin-form-layout-row-spacingremains at0, ensuring backwards compatibility until Vaadin 25 where it will be dropped.Warning
The change is still considered breaking because it can increase the default intrinsic width of dialogs with form layouts. See vaadin/flow-components#2201, #949, and CRUD screenshots in this PR for more insights.
Part of #8583
Type of change