refactor: simplify observers setup, improve tests #8622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
commented
Feb 3, 2025
| @@ -598,32 +581,25 @@ describe('form layout', () => { | |||
| expect(unhiddenItemWidth).to.equal(itemWidth); | |||
| }); | |||
|
|
|||
| it('should update layout after updating a colspan attribute on the lazily stamped node', async () => { | |||
| container.push('items', { label: 'Email', colspan: 1 }); | |||
There was a problem hiding this comment.
note: It seems pointless to test that FormLayout picks up on DOM changes caused by Polymer specifically.
vursen
commented
Feb 3, 2025
vursen
commented
Feb 3, 2025
|
|
||
| /** @private */ | ||
| _getObservableNodes(nodeList) { | ||
| const ignore = ['template', 'style', 'dom-repeat', 'dom-if']; |
There was a problem hiding this comment.
note: This seems like an old logic to support Polymer templates, which we no longer support, as far as I remember.
vursen
force-pushed
the
refactor/form-layout/simplify-observers-and-tests
branch
from
64027f0 to
15137a6
Compare
…simplify-observers-and-tests
…simplify-observers-and-tests
|
web-padawan
approved these changes
Feb 4, 2025
1 task
DiegoCardoso
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR simplifies the MutationObserver setup in FormLayout by using
subtree: trueinstead of observing each child element individually. The PR also improves the tests to ensure they cover these observers. Previously, the tests were passing even without the observers because adding and removing new elements triggered a resize event, which in turn triggered a layout update expected by the test.Depends on
Part of #8583
Type of change