Added tester for RouterLink. #1810
Conversation
| var targetlessRouterLink = $routerLinkView.find(RouterLink.class) | ||
| .withText("No Target") | ||
| .single(); |
There was a problem hiding this comment.
I suggest making all RouterLink components as package protected class fields so that the test can directly wrap the instance, without relying on find.
This allows to prevent false positives in tests because of potential bugs in the component locator.
IMO it also simplifies the test code
There was a problem hiding this comment.
I would revert changes to this file that are not related to RouterLink
| */ | ||
| public Component click() { | ||
| if (getRoute().isEmpty()) { | ||
| throw new IllegalStateException(); |
There was a problem hiding this comment.
This exception requires an explanatory message
| * | ||
| * @return navigated view | ||
| */ | ||
| public Component click() { |
There was a problem hiding this comment.
What about returning HasElement to be consistent with AnchorTester?
There was a problem hiding this comment.
The method should ensure that the component is usable by calling ensureComponentIsUsable().
I mean, the check is done indirectly done by getPath(), but I think it would be good to make it more explicit.
| Assertions.assertDoesNotThrow(() -> $targetView.find(Span.class) | ||
| .withText("Static Target View") | ||
| .single()); |
There was a problem hiding this comment.
Same as for RouterLink, what about having the Span as a package protected field and simply assert on its getText()?
mcollovati
force-pushed
the
feature/#1805-RouterLinkTester
branch
from
dc98d56 to
f2142aa
Compare
vaadin-testbench-unit-shared/src/main/java/com/vaadin/testbench/unit/TesterWrappers.java
Show resolved
Hide resolved
Description
Adds missing
ComponentTesterforRouterLink. (Attempting to useAnchorTesterin its place results in an error due toAnchorandRouterLinkbeing differentComponents.Tester methods include
getHrefgetPathgetQueryParametersgetRouteclickFixes #1805
Type of change
Checklist
Additional for
Featuretype of change