Allow using unserializable components #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamasmak
changed the title
mcollovati
requested changes
Feb 5, 2025
...etes-kit-starter/src/main/java/com/vaadin/kubernetes/starter/sessiontracker/SessionUtil.java
Show resolved
Hide resolved
...c/main/java/com/vaadin/kubernetes/starter/sessiontracker/UnserializableComponentWrapper.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/vaadin/kubernetes/starter/sessiontracker/UnserializableComponentWrapper.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/vaadin/kubernetes/starter/sessiontracker/UnserializableComponentWrapper.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/vaadin/kubernetes/starter/sessiontracker/UnserializableComponentWrapper.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/vaadin/kubernetes/starter/sessiontracker/UnserializableComponentWrapper.java
Show resolved
Hide resolved
...c/main/java/com/vaadin/kubernetes/starter/sessiontracker/UnserializableComponentWrapper.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/vaadin/kubernetes/starter/sessiontracker/UnserializableComponentWrapper.java
Outdated
Show resolved
Hide resolved
...in/java/com/vaadin/kubernetes/starter/sessiontracker/serialization/TransientAwareHolder.java
Outdated
Show resolved
Hide resolved
...tarter/src/test/java/com/vaadin/kubernetes/starter/sessiontracker/SessionSerializerTest.java
Show resolved
Hide resolved
mcollovati
requested changes
Feb 5, 2025
...etes-kit-starter/src/main/java/com/vaadin/kubernetes/starter/sessiontracker/SessionUtil.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/vaadin/kubernetes/starter/sessiontracker/UnserializableComponentWrapper.java
Outdated
Show resolved
Hide resolved
mcollovati
previously approved these changes
Feb 5, 2025
mcollovati
reviewed
Feb 5, 2025
...it-starter/src/main/java/com/vaadin/kubernetes/starter/sessiontracker/SessionSerializer.java
Outdated
Show resolved
Hide resolved
mcollovati
dismissed
their stale review
I did a test in a local cluster with the Spreadsheet component, and unfortunately, it seems there's that doesn't work. When switching node, the contents of the spreadsheet are not restored.
I need to do additional tests
mcollovati
reviewed
Feb 5, 2025
...c/main/java/com/vaadin/kubernetes/starter/sessiontracker/UnserializableComponentWrapper.java
Outdated
Show resolved
Hide resolved
mcollovati
approved these changes
Feb 5, 2025
mcollovati
reviewed
Feb 6, 2025
...c/main/java/com/vaadin/kubernetes/starter/sessiontracker/UnserializableComponentWrapper.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #141