Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Reference contributor for Hilla translate method usage #288

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MarcinVaadin
Copy link
Member

Fixes #232

Copy link

Artifact build on last commit: distributions.zip.
For MacOS users: there is a zip inside this zip and Finder unzips them both at once. Use unzip distributions.zip from Terminal or check solution for Archive Manager.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

@mgarciavaadin mgarciavaadin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for Hilla, good job!
I did not notice any change in Flow though, what should I expect?

@MarcinVaadin
Copy link
Member Author

MarcinVaadin commented Feb 3, 2025

I did not notice any change in Flow though, what should I expect?

With this update only vaadin-i18n.translations bundle properties are considered. Without that fix if you use getTranslation('server.port') spring application.properties will be opened which was wrong.

@mgarciavaadin
Copy link
Contributor

I did not notice any change in Flow though, what should I expect?

With this update only vaadin-i18n.translations bundle properties are considered. Without that fix if you use getTranslation('server.port') spring application.properties will be opened which was wrong.

Then I understood correctly and it is not working for Flow ;) . At least it still is showing the application properties file as options.

Screenshot 2025-02-03 at 14 17 09

ping @MarcinVaadin

Copy link
Contributor

@mgarciavaadin mgarciavaadin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the Flow use case I still see all the application.properties options suggested if I click on a translate("server.port") translation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update i18n references contributor
2 participants