Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add fallback for Playwright-provided browser #3204

Merged
merged 8 commits into from
Feb 5, 2025
Merged

Conversation

Lodin
Copy link
Contributor

@Lodin Lodin commented Feb 4, 2025

If you want to get rid of an additional Chrome binary in your node_modules, you can add the following environment variables:

PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD=1
CHROME_BIN=/opt/google/chrome/chrome # or any other path to your Chrome binary

Note: if you have PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD set without CHROME_BIN, it will throw an error.
Note: for this change to take effect you have to run npm ci.

@Lodin Lodin added the hilla Issues related to Hilla label Feb 4, 2025
@Lodin Lodin requested review from platosha, cromoteca and taefi February 4, 2025 12:45
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.91%. Comparing base (2c651bb) to head (c50f387).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3204   +/-   ##
=======================================
  Coverage   86.91%   86.91%           
=======================================
  Files         118      118           
  Lines        8191     8191           
  Branches     1256     1256           
=======================================
  Hits         7119     7119           
  Misses       1058     1058           
  Partials       14       14           
Flag Coverage Δ
unittests 86.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lodin
Copy link
Contributor Author

Lodin commented Feb 5, 2025

This PR changes the workflow, so the correct Validation is here

# Conflicts:
#	package-lock.json
Copy link

sonarqubecloud bot commented Feb 5, 2025

@Lodin Lodin merged commit a53482d into main Feb 5, 2025
23 of 25 checks passed
@Lodin Lodin deleted the test/vitest-fallback branch February 5, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hilla Issues related to Hilla
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants