Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update frontend dependency to fix snapshot failure #3197

Closed
wants to merge 1 commit into from

Conversation

ZheSun88
Copy link
Contributor

@ZheSun88 ZheSun88 commented Feb 3, 2025

No description provided.

Copy link

sonarqubecloud bot commented Feb 3, 2025

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (24.6@c5c2b01). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             24.6    #3197   +/-   ##
=======================================
  Coverage        ?   92.69%           
=======================================
  Files           ?       85           
  Lines           ?     3164           
  Branches        ?      775           
=======================================
  Hits            ?     2933           
  Misses          ?      181           
  Partials        ?       50           
Flag Coverage Δ
unittests 92.69% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@taefi taefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we get rid of react-router-dom dep in the ITs, and replace all the imports to be from react-router. I'll experiment this in a separate PR.

@taefi
Copy link
Contributor

taefi commented Feb 3, 2025

I suggest we get rid of react-router-dom dep in the ITs, and replace all the imports to be from react-router. I'll experiment this in a separate PR.

Unfortunately, this needs upgrading the react-rotuer to 7.+ (as done in main), so not a good idea for 24.6 patch releases.

@Lodin
Copy link
Contributor

Lodin commented Feb 3, 2025

@ZheSun88, I believe, the issue is fixed by #3199

@Lodin Lodin closed this Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants