Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: replace Testbench tests with Playwright Java & TS (v24.4) #45

Merged
merged 6 commits into from
Oct 7, 2024

Conversation

manolo
Copy link
Member

@manolo manolo commented May 28, 2024

No description provided.

@manolo manolo force-pushed the playwright-v24.4 branch from 477735a to b192683 Compare May 28, 2024 17:48
Copy link

github-actions bot commented May 28, 2024

Unit Test Results

12 tests   12 ✔️  20s ⏱️
  4 suites    0 💤
  2 files      0

Results for commit bf4dc8a.

♻️ This comment has been updated with latest results.

@manolo manolo requested review from mshabarov and platosha May 28, 2024 18:17
@manolo manolo force-pushed the playwright-v24.4 branch from 54b5813 to 0b8e135 Compare May 29, 2024 14:38
@mshabarov mshabarov changed the base branch from v24.4 to v24 September 26, 2024 14:58
@mshabarov
Copy link
Contributor

Looks like the tests are passing now on top of the latest V24 versions.
Let's discuss which of my changes can be applied and which should be replaced by a proper solution.
Here what I'm having doubts about:

  • "noEmit": true option, I got compilation errors if .js and .js.map are generated,
  • ?continue workaround

@mshabarov mshabarov merged commit f0719ec into v24 Oct 7, 2024
1 of 3 checks passed
@mshabarov mshabarov deleted the playwright-v24.4 branch October 7, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants