Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: replace Testbench tests with Playwright Java & TS (v24.3) #44

Closed
wants to merge 23 commits into from
Closed

feat!: replace Testbench tests with Playwright Java & TS (v24.3) #44

wants to merge 23 commits into from

Conversation

manolo
Copy link
Member

@manolo manolo commented May 28, 2024

No description provided.

vaadin-bot and others added 22 commits January 16, 2024 11:51
@vaadin-bot
chore: Update Hilla 2.5.6
e0fa3c2
@ZheSun88
update vaadin.version to 24.3.3
564914f
@ZheSun88
Merge pull request #16 from vaadin/update-hilla-2.5.6-1705405701216
0a7d42a 
chore: Update Hilla 2.5.6
@tarekoraby
Update README
7b6c110
@vaadin-bot
chore: Update Vaadin 24.3.4
be99662
@ZheSun88
Merge pull request #19 from vaadin/update-vaadin-24.3.4-1707741195493
884a9b3 
chore: Update Vaadin 24.3.4
@vaadin-bot
chore: Update Vaadin 24.3.5
f35d389
@ZheSun88
Merge pull request #20 from vaadin/update-vaadin-24.3.5-1707832206575
8d6d9b8 
chore: Update Vaadin 24.3.5
@vaadin-bot
chore: Update Vaadin 24.3.6
3b2abaa
@ZheSun88
Merge pull request #23 from vaadin/update-vaadin-24.3.6-1709543808037
0105b19 
chore: Update Vaadin 24.3.6
@vaadin-bot
chore: Update Vaadin 24.3.7
dcfefeb
@ZheSun88
Merge pull request #24 from vaadin/update-vaadin-24.3.7-1710263455608
fa60629 
chore: Update Vaadin 24.3.7
@vaadin-bot
chore: Update Vaadin 24.3.8
d156f74
@ZheSun88
Merge pull request #28 from vaadin/update-vaadin-24.3.8-1711366327128
0e8048e 
chore: Update Vaadin 24.3.8
@vaadin-bot
chore: Update Vaadin 24.3.9
2046b62
@ZheSun88
Merge pull request #31 from vaadin/update-vaadin-24.3.9-1712125568500
20f806b 
chore: Update Vaadin 24.3.9
@vaadin-bot
chore: Update Vaadin 24.3.10
944ba59
@ZheSun88
Merge pull request #36 from vaadin/update-vaadin-24.3.10-1713876170358
227e4ee 
chore: Update Vaadin 24.3.10
@vaadin-bot
chore: Update Vaadin 24.3.11
89187b7
@ZheSun88
Merge pull request #39 from vaadin/update-vaadin-24.3.11-1714990980353
750d8d9 
chore: Update Vaadin 24.3.11
@vaadin-bot
chore: Update Vaadin 24.3.12
909fdb6
@ZheSun88
Merge pull request #42 from vaadin/update-vaadin-24.3.12-1715604610475
3518116 
chore: Update Vaadin 24.3.12
@manolo manolo force-pushed the playwright-v24 branch 2 times, most recently from 2270f87 to 0e27669 Compare May 28, 2024 15:21
@manolo manolo changed the title feat!: replace Testbench tests with Playwright Java & TS feat!: replace Testbench tests with Playwright Java & TS (v24.3) May 28, 2024
@github-actions GitHub Actions
Copy link

Unit Test Results

5 tests   - 5   5 ✔️  - 5   9s ⏱️ -6s
1 suites  - 1   0 💤 ±0 
1 files    - 1   0 ❌ ±0 

Results for commit 4f225f6. ± Comparison against base commit 3518116.

This pull request removes 6 and adds 1 tests. Note that renamed tests count towards both. 
org.vaadin.example.FlowViewIT ‑ testEnterShowsHelloUserNotificationWhenUserIsNotEmpty
org.vaadin.example.HillaViewIT ‑ clickingButtonShowsNotification
org.vaadin.example.HillaViewIT ‑ clickingButtonTwiceShowsTwoNotifications
org.vaadin.example.HillaViewIT ‑ testClickButtonShowsHelloAnonymousUserNotificationWhenUserNameIsEmpty
org.vaadin.example.HillaViewIT ‑ testClickButtonShowsHelloUserNotificationWhenUserIsNotEmpty
org.vaadin.example.HillaViewIT ‑ testEnterShowsHelloUserNotificationWhenUserIsNotEmpty

org.vaadin.example.FlowViewIT ‑ userEntersNameAndClicksButton

@manolo manolo requested review from mshabarov and platosha May 28, 2024 18:17
@mshabarov
Copy link
Contributor

I think this PR is not needed as v24 now has PlayWright tests.

@mshabarov mshabarov closed this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshabarov mshabarov Awaiting requested review from mshabarov

@platosha platosha Awaiting requested review from platosha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@manolo @mshabarov @vaadin-bot @ZheSun88 @tarekoraby