Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use documentTitleSignal for page title #41

Merged
merged 2 commits into from
May 15, 2024
Merged

fix: Use documentTitleSignal for page title #41

merged 2 commits into from
May 15, 2024

Conversation

mshabarov
Copy link
Contributor

Uses signal for dynamically updated page title.

Part of vaadin/flow#19200

Copy link

github-actions bot commented May 13, 2024

Unit Test Results

10 tests  ±0   10 ✔️ ±0   26s ⏱️ ±0s
  2 suites ±0     0 💤 ±0 
  2 files   ±0     0 ±0 

Results for commit add4b92. ± Comparison against base commit 4856cda.

♻️ This comment has been updated with latest results.

@mshabarov mshabarov marked this pull request as ready for review May 15, 2024 10:56
@mshabarov mshabarov requested a review from tltv May 15, 2024 12:11
@mshabarov mshabarov merged commit e5dd2a0 into v24.4 May 15, 2024
3 checks passed
@mshabarov mshabarov deleted the page-title branch May 15, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants