refactor: use side-nav component #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r/use-side-nav # Conflicts: # pom.xml # src/main/frontend/views/@layout.tsx # src/main/frontend/views/login.tsx
mshabarov
approved these changes
Apr 23, 2024
…r/use-side-nav # Conflicts: # package-lock.json # package.json # src/main/frontend/views/@layout.tsx
mshabarov
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the automatically generated nav menu to use the
SideNavcomponent. Also updates React component imports to import from the index module.This aligns with the changes done here: vaadin/skeleton-starter-hilla-react#190
Currently set to merge against #33 which introduces the automatic menu generation in the first place.