feat: Use RoutesBuilder API

[mshabarov]

No description provided.

[github-actions]

Unit Test Results

10 tests   10 ✔️  25s ⏱️
  2 suites    0 💤
  2 files      0 ❌

Results for commit f0ad36b.

♻️ This comment has been updated with latest results.

[tltv]

Suggesting import format to be same everywhere with a spaces around inside import { ... }.

[caalador]

Looks fine, but it works a bit strange.
It had all the routes for the different users, also the ones that are not applicable for the user.
So the Flow view is there for user, which leads to a Reason: Access is denied by annotations on the view..
And Hilla User is there for admin which leads to the login view, even though you are already logged in.

[mshabarov]

It had all the routes for the different users, also the ones that are not applicable for the user.
So the Flow view is there for user, which leads to a Reason: Access is denied by annotations on the view..
And Hilla User is there for admin which leads to the login view, even though you are already logged in.

Yeah, I'll try to change that by editing the main layout impl.

[mshabarov]

Unfortunately, I couldn't manage to make it work with the createMenuItems method, because:

1. Any item returned by createMenuItems seems to not have rolesAllowed, nor loginRequired properties, I don't know how could I get the authorities with this API
2. Authorities for server-side views aren't sent to the client and basically they aren't filtered by server (this feature haven't been implemented yet).

Thus, I'm not sure how can I filter the menu items by access (in role and is logged in).

I pushed an ugly checking codes that works, but we have to replace it with a proper way.

[mshabarov]

UPD:
createMenuItems function now checks the access control automatically, but this feature hasn't been released in any alpha yet. Should be available in Hilla 24.4.0.alpha22, and then I can change my main layout impl to use:

<nav>
    {
         createMenuItems().map(({ to, icon, title }) => (
                <NavLink className={navLinkClasses} to={to} key={to}>
                      {title}
                </NavLink>
              ))
         },
         { flowIsInRole ? (
                <NavLink to={'/flow'} className={navLinkClasses}>
                      Flow Admin
                </NavLink>
         ) : null}
</nav>

Later on, when we implement this feature in Flow, we will be able to even remove that part

         { flowIsInRole ? (
                <NavLink to={'/flow'} className={navLinkClasses}>
                      Flow Admin
                </NavLink>
         ) : null}

as server-side routes will be checked agains access control and added into createMenuItems output list, if have access.

So we should wait for Vaadin 24.4.0.alpha22 release, remove my workaround for Hilla view, then wait for the above feature in Flow and just leave the following codes:

<nav>
    {
         createMenuItems().map(({ to, icon, title }) => (
                <NavLink className={navLinkClasses} to={to} key={to}>
                      {title}
                </NavLink>
              ))
         }
</nav>

FYI @caalador @tltv