Skip to content

fix: capture and highlight stderr output from dspublisher process #4745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 10, 2025
Merged

fix: capture and highlight stderr output from dspublisher process #4745

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
42e60ef
fix: capture and highlight stderr output from dspublisher process
tomivirkki Nov 7, 2025
ccb3b16
Fix typo
tomivirkki Nov 7, 2025
48eb4bd
Merge branch 'main' into chore/log-dsp-stderr
tomivirkki Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions dspublisher/dspublisher-scripts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,13 @@ async function checkPreConditions() {
resolve();
} else {
reject(
new Error('Maven is not installed. Plase make sure it is installed and in your PATH.')
new Error('Maven is not installed. Please make sure it is installed and in your PATH.')
);
}
});

ps.on('error', () => {
new Error('Maven is not installed. Plase make sure it is installed and in your PATH.');
new Error('Maven is not installed. Please make sure it is installed and in your PATH.');
});
});

Expand Down Expand Up @@ -407,6 +407,14 @@ async function execute(shellCommand, phases, ignoredLogSignals = []) {
phase.done = true;
}
});

ps.stderr.on('data', (data) => {
if (ignoredLogSignals.every((signal) => !data.toString().includes(signal))) {
const redColor = '\x1b[31m';
const defaultColor = '\x1b[0m';
logProgress(progressState, `${redColor}${data.toString()}${defaultColor}`);
}
});
});
}

Expand Down