Skip to content

Conversation

@caalador
Copy link
Contributor

@caalador caalador commented Nov 4, 2025

Update the npm assets referencing to match
new functionality.

part of vaadin/flow#22515

@github-actions
Copy link

github-actions bot commented Nov 4, 2025

AI Language Review

  • In the section under "[#fonts-and-images-from-npm]", the phrase "starting the request as assets/{npm_asset_path}" seems unclear and unnecessary. Consider rephrasing or removing if this is not providing critical information.
  • In the example usage of the assets field, the description of the SVG file path needs to ensure consistency with the description. It mentions "assets/fontawesome/icons/snowflake.svg" in the code example, but in the explanation, it refers to "VAADIN/static/assets/fontawesome/icons/snowflake.svg". Confirm the intended asset directory to avoid confusion.

Update the npm assets referencing to match
new functionality.

part of vaadin/flow#22515
@caalador caalador force-pushed the issues/22515-npm-assets branch from 1f43afc to 0f2d01f Compare November 4, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants