-
Notifications
You must be signed in to change notification settings - Fork 214
Add Flex Layout documentation #4700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v24
Are you sure you want to change the base?
Conversation
AI Language ReviewIn the review of the provided files, there are no changes or issues that require improvement related to edited lines or sections. The modifications from the old files to the new ones seem to address the additions correctly, and the AsciiDoc files are appropriately descriptive, maintaining clarity and consistency. Thus, no specific comments or corrections are needed on the revised parts. |
6fd6587 to
df56aaf
Compare
|
We're actually trying to get away from the need for FlexLayout entirely, so I'm not sure we want to now start promoting it like this. HL now has native support for wrapping, so the only feature it has that HL and VL lacks is |
@rolfsmeds I guess for HL and VL it would only make sense to have "reverse" direct changes, but a use case where you'd want to switch between HL and VL isn't covered I guess. Wondering if it would be useful to add a disclamer on top, that the user should prefer to use HL or VL instead of this component, unless they have some specific scenario where the direction change is necessary? Since its not a deprecated component, feels like it should be documented. |
|
Even for scenarios where direction change is needed, I think it makes more sense to use utility classes or just plain css with a We could also consider including FlexLayout on the HTML Elements page, as it's really just a |
|
@rolfsmeds |
|
I think a separate section like for the |
Solves
#2124