Skip to content

Add note and code example of disabling server modality #4404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 10, 2025

Conversation

TatuLund
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Jun 27, 2025

AI Language Review

In the updated documentation for the Dialog component, a new section under Modality includes a NOTE element about disabling server-side modality. This addition is useful and offers practical insight into how to disable server-side modality after a dialog has opened. However, consider using consistent indentation in the code snippet to improve readability. Additionally, ensure there are no loose indentation lines in the snippet for a cleaner appearance.

The rest of the documentation seems consistent with the existing style and guidelines.

@@ -199,6 +199,21 @@ endif::[]

Usually, non-modal dialogs should be draggable, so that the user can move them to access the user interface beneath.

[NOTE]
In some use cases you may want to disable the server side modality. This can be done after Dialog has been opened.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a new section (e.g., === Disabling Modality) instead of an admonition? What are those cases, could we offer an example? And why do I have to do it after the dialog has been opened?

@mshabarov mshabarov requested a review from mcollovati June 30, 2025 11:42
Copy link
Contributor

@mcollovati mcollovati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example code is OK.
I have no strong opinion on Jouni's comment

@TatuLund TatuLund merged commit 968e2fe into latest Jul 10, 2025
4 of 5 checks passed
@TatuLund TatuLund deleted the dialog-disable-server-modality branch July 10, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants