-
Notifications
You must be signed in to change notification settings - Fork 209
docs: document FormLayout auto-responsive mode #4225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: latest
Are you sure you want to change the base?
Conversation
src/main/java/com/vaadin/demo/component/formlayout/FormLayoutColspan.java
Outdated
Show resolved
Hide resolved
5d3bcdc
to
f69f9c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 30 out of 31 changed files in this pull request and generated no comments.
Files not reviewed (1)
- articles/components/form-layout/index.adoc: Language not supported
Comments suppressed due to low confidence (2)
frontend/demo/component/formlayout/react/form-layout-steps-basic.tsx:27
- Verify whether the extra empty within the SplitLayout is required for layout purposes; if not, consider removing it to simplify the component structure.
<div></div>
frontend/demo/component/formlayout/form-layout-steps-basic.ts:11
- The custom element name has been updated to 'form-layout-steps-basic' for clarity. Please ensure that all documentation and usage references are updated accordingly.
@customElement('form-layout-steps-basic')
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but we should perhaps not merge it to latest
until we have a beta of 24.8 (i.e. last week of May)
Fixes #4177