Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow both GET and POST requests for /auth/logout API endpoint #9887

Merged
merged 1 commit into from
Mar 4, 2025
+3 −0
Merged

Allow both GET and POST requests for /auth/logout API endpoint #9887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions java/code/src/com/suse/manager/api/HttpApiRegistry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ public static Set<String> getUnautenticatedRoutes() {
*/
private void registerAuthEndpoints() {
registrationHelper.addPostRoute(HTTP_API_ROOT + "auth/login", LoginController::apiLogin);
registrationHelper.addPostRoute(HTTP_API_ROOT + "auth/logout", withUser(LoginController::logout));
registrationHelper.addGetRoute(HTTP_API_ROOT + "auth/logout", withUser(LoginController::logout));
}

Expand Down
1 change: 1 addition & 0 deletions java/code/src/com/suse/manager/api/test/HttpApiRegistryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ public void testInitRoutes() {
context().checking(new Expectations() {{
// Auth routes are added in all cases
oneOf(helper).addPostRoute(with("/manager/api/auth/login"), with(any(Route.class)));
oneOf(helper).addPostRoute(with("/manager/api/auth/logout"), with(any(Route.class)));
oneOf(helper).addGetRoute(with("/manager/api/auth/logout"), with(any(Route.class)));

// Test routes
Expand Down
1 change: 1 addition & 0 deletions java/spacewalk-java.changes.cbbayburt.logout-api-get
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Allow both GET and POST requests for /auth/logout API endpoint
Loading