-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SonarCloud error reduction: HTML issues #9884
base: master
Are you sure you want to change the base?
Conversation
👋 Hello! Thanks for contributing to our project. You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/9884/checks If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code. Reference tests: KNOWN ISSUES Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience. For more tips on troubleshooting, see the troubleshooting guide. Happy hacking! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering, are we even still using MX4J
?
grep -ir MX4J java/
only returns this license file as relevant result, and one unrelated entry at code/src/com/suse/manager/reactor/utils/test/productdata/repositories.json
So not sure if the fix here would be to just remove the file? Could this be a leftover from the spacewalk times?
I had the confirmation this software is not pointed anywhere, so I removed the file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please update the PR description :-)
What does this PR change?
Fixes SonarCloud issues with HTML. All issues were located in a single old-style license HTML file.
Since the license referred to MX4J, which is no longer used anywhere, the license has been removed.
GUI diff
No difference.
Documentation
Test coverage
Links
Issue(s): #9878
Changelogs