Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebrand the product to Multi-Linux Manager #9883

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

deneb-alpha
Copy link
Contributor

@deneb-alpha deneb-alpha commented Mar 3, 2025

What does this PR change?

Rebrand the product to Multi-Linux Manager

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite

Links

Issue(s): https://github.com/SUSE/spacewalk/issues/26379 https://github.com/SUSE/spacewalk/issues/26544

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

@deneb-alpha deneb-alpha added the merge-candidate Meaning it needs to be considered for merging when the master branch is frozen label Mar 3, 2025
@deneb-alpha deneb-alpha self-assigned this Mar 3, 2025
@deneb-alpha deneb-alpha requested a review from a team as a code owner March 3, 2025 17:08
Copy link
Contributor

@aaannz aaannz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just checking, is the labelprefix without dashes? (com.suse.multilinuxmanager)

@deneb-alpha
Copy link
Contributor Author

deneb-alpha commented Mar 3, 2025

LGTM

Just checking, is the labelprefix without dashes? (com.suse.multilinuxmanager)

funny story... I think that prefix is not used currently. at least, I didn't find traces of it in the existing dockerfiles. but, just in case, I can branch all the containers, not just init and server.

./init-image/Dockerfile:49:# labelprefix=com.suse.multilinuxmanager.init
./server-image/Dockerfile:96:# labelprefix=com.suse.multilinuxmanager.server
./proxy-httpd-image/Dockerfile:47:# labelprefix=com.suse.multilinuxmanager.proxy-httpd
./proxy-salt-broker-image/Dockerfile:38:# labelprefix=com.suse.multilinuxmanager.proxy-salt-broker
./proxy-squid-image/Dockerfile:55:# labelprefix=com.suse.multilinuxmanager.proxy-squid
./proxy-ssh-image/Dockerfile:43:# labelprefix=com.suse.multilinuxmanager.proxy-ssh
./proxy-tftpd-image/Dockerfile:42:# labelprefix=com.suse.multilinuxmanager.proxy-tftpd
./server-attestation-image/Dockerfile:25:# labelprefix=com.suse.multilinuxmanager.server-attestation
./server-hub-xmlrpc-api-image/Dockerfile:17:# labelprefix=com.suse.multilinuxmanager.server-hub-xmlrpc-api
./server-migration-14-16-image/Dockerfile:23:# labelprefix=com.suse.multilinuxmanager.server-migration-14-16
./server-postgresql-image/Dockerfile:18:# labelprefix=com.suse.multilinuxmanager.server-postgresql
./server-saline-image/Dockerfile:35:# labelprefix=com.suse.multilinuxmanager.server-saline

not sure what should go there TBH. 🤔

I checked https://specs.opencontainers.org/image-spec/annotations/ but it only mentions to use reverse domain notation but to my knowledge that could also include dashes I think.

EDIT2: it seems that the usage or not of dashes is up to us. let's keep the label simpler omitting dashes.

I'll merge the PR as it is now

@deneb-alpha deneb-alpha merged commit 90b06e3 into uyuni-project:master Mar 3, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-candidate Meaning it needs to be considered for merging when the master branch is frozen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants