Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issv3: add xmlrpc hub apis #9866

Open
wants to merge 11 commits into
base: issv3-2
Choose a base branch
from

Conversation

CDellaGiusta
Copy link
Contributor

What does this PR change?

Adding some missing XMLRPC entries for HubManager

GUI diff

No difference.

  • DONE

Documentation

Test coverage

  • Unit tests were added
  • DONE

Links

Issue(s):
Port(s):

  • DONE

Changelogs

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

@CDellaGiusta CDellaGiusta requested review from a team as code owners February 28, 2025 09:14
@CDellaGiusta CDellaGiusta requested review from wweellddeerr and removed request for a team February 28, 2025 09:14
Copy link
Contributor

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕

You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/9866/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/9866/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

* #array_end()
*/
@ReadOnly
public List<Channel> listAllPeripheralChannels(User loggedInUser) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this is missleading as it sound like you would call it on a hub and it connect to a peripheral server to get the data.
But hubManager.collectAllChannels() just get the local channels.
I think we need to check if we need this at all for any workflow which makes sense to develop via API.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make sense out of this we should specify the peripheral server and return all channels from that given peripheral.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restructured

@CDellaGiusta CDellaGiusta force-pushed the issv3-add-xmlrpc-hub-apis branch from 8f27b10 to 47a06f3 Compare March 3, 2025 15:08
@CDellaGiusta CDellaGiusta requested review from mcalmer and mackdk March 3, 2025 15:09
@CDellaGiusta CDellaGiusta force-pushed the issv3-add-xmlrpc-hub-apis branch from 47a06f3 to 7efe924 Compare March 3, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants