-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issv3: add xmlrpc hub apis #9866
base: issv3-2
Are you sure you want to change the base?
Issv3: add xmlrpc hub apis #9866
Conversation
👋 Hello! Thanks for contributing to our project. You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/9866/checks If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code. Reference tests: KNOWN ISSUES Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience. For more tips on troubleshooting, see the troubleshooting guide. Happy hacking! |
java/code/src/com/redhat/rhn/frontend/xmlrpc/ContentSyncException.java
Outdated
Show resolved
Hide resolved
* #array_end() | ||
*/ | ||
@ReadOnly | ||
public List<Channel> listAllPeripheralChannels(User loggedInUser) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also this is missleading as it sound like you would call it on a hub and it connect to a peripheral server to get the data.
But hubManager.collectAllChannels()
just get the local channels.
I think we need to check if we need this at all for any workflow which makes sense to develop via API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make sense out of this we should specify the peripheral server and return all channels from that given peripheral.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
restructured
…ry in suseISSPeripheral
8f27b10
to
47a06f3
Compare
47a06f3
to
7efe924
Compare
What does this PR change?
Adding some missing XMLRPC entries for HubManager
GUI diff
No difference.
Documentation
Test coverage
Links
Issue(s):
Port(s):
Changelogs
If you don't need a changelog check, please mark this checkbox:
Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run: