-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: add build test images to ghcr.io #9843
CI: add build test images to ghcr.io #9843
Conversation
👋 Hello! Thanks for contributing to our project. You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/9843/checks If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code. Reference tests: KNOWN ISSUES Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience. For more tips on troubleshooting, see the troubleshooting guide. Happy hacking! |
40720e4
to
afab349
Compare
425a9e7
to
c50f6f2
Compare
@@ -0,0 +1,15 @@ | |||
FROM localhost:5002/opensuse/leap:15.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just out of curiousity, why do we not use Leap 15.6 or at least 15.5?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no idea. I am using what we are already using at the other build profiles.
93ea3ce
to
ae8d186
Compare
@srbarrios I plan to split it into 2 PR, one that adds the images to the ghcr.io, and one that uses that, so we do not break anything. |
This is the first step to fix SUSE/spacewalk#25948 We need the test images in ghcr.io so we can later pull them and push them to the authenticated and non-authenticated registries that we use when running tests that build container images based on the content of the registries. Signed-off-by: Jordi Massaguer Pla <[email protected]>
This way, we can later use these images in the build container tests Signed-off-by: Jordi Massaguer Pla <[email protected]>
To be used in the build container tests. Signed-off-by: Jordi Massaguer Pla <[email protected]>
3064b11
to
d6917aa
Compare
What does this PR change?
This is the first step to fix https://github.com/SUSE/spacewalk/issues/25948 We need the test images in ghcr.io so we can pull them and push them to the authenticated and non-authenticated registries that we use when running tests that build container images based on the content of the registries.
It is important that the images are in ghcr.io, because we do not want to pull images from the opensuse mirror infrastructure, nor docker hub, during the test. First, for stability, second, because there are rate limits.
GUI diff
No difference.
Documentation
Test coverage
ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite
No tests
DONE
Links
Issue(s): https://github.com/SUSE/spacewalk/issues/25948
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!