-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ansible] Ansible Managed entitlement and default playbook/inventory paths #9812
base: master
Are you sure you want to change the base?
Conversation
👋 Hello! Thanks for contributing to our project. You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/9812/checks If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code. Reference tests: KNOWN ISSUES Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience. For more tips on troubleshooting, see the troubleshooting guide. Happy hacking! |
1e15baf
to
ac2995f
Compare
3f44e49
to
1381f96
Compare
ec3030c
to
6e24bb9
Compare
6e3c1a6
to
3913c8d
Compare
Nothing to review on the frontend. It looks like there's a layout bug in the playbook directories input and related areas, do we have a ticket for that? |
Card created https://github.com/SUSE/spacewalk/issues/26555 |
b90dc2e
to
1d3ae92
Compare
Signed-off-by: Pascal Arlt <[email protected]>
Signed-off-by: Pascal Arlt <[email protected]>
Signed-off-by: Pascal Arlt <[email protected]>
Signed-off-by: Pascal Arlt <[email protected]>
Signed-off-by: Pascal Arlt <[email protected]>
Signed-off-by: Pascal Arlt <[email protected]>
Signed-off-by: Pascal Arlt <[email protected]>
Signed-off-by: Pascal Arlt <[email protected]>
Signed-off-by: Pascal Arlt <[email protected]>
Signed-off-by: Pascal Arlt <[email protected]>
Signed-off-by: Pascal Arlt <[email protected]>
create/update/remove Signed-off-by: Pascal Arlt <[email protected]>
Signed-off-by: Pascal Arlt <[email protected]>
Signed-off-by: Pascal Arlt <[email protected]>
Signed-off-by: Pascal Arlt <[email protected]>
Signed-off-by: Pascal Arlt <[email protected]>
Signed-off-by: Pascal Arlt <[email protected]>
Signed-off-by: Pascal Arlt <[email protected]>
Signed-off-by: Pascal Arlt <[email protected]>
Signed-off-by: Pascal Arlt <[email protected]>
1d3ae92
to
0c23d86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tested the new code on my local env and everything works as they should 👍
Also, thanks for the nicely organized code and the commits. It makes the review much easier.
One thing I couldn't figure out is after I'm done testing the whole feature, somehow my clients could no longer access any channels anymore. I tried recreating the channels, re-registering clients with no success. I have absolutely no idea if it's caused by this patch at all, but I think it's something to be aware of. I'll try it once again with a fresh setup next week, and until I figure it out, I'll assume it's just a quirk in my setup.
@Etheryte, if you have the time to take care of the CSS issues mentioned above before the master
is unlocked for the next release, feel free to just add a commit for the fix on top of this PR.
What does this PR change?
Enhancements to the existing Ansible integration
This PR implements the following points of https://github.com/SUSE/spacewalk/issues/25367
I also decided to remove all existing Ansible paths for a control node when the
Ansible Control Node
entitlements is removed, to make the data we store in the db consistent and make managingAnsible Managed
systems easier.GUI diff
After:
Filter by System Type:

Ansible Managed
in the system listAdd

Ansible Managed
entitlementAdd new

Inventory Refresh
actionAdd default playbook and inventory paths on adding a control node

Documentation
Documentation issue was created: [TODO]
(OPTIONAL) Documentation PR
DONE
Test coverage
Unit tests were added
Cucumber tests were added
DONE
Links
Issue(s): https://github.com/SUSE/spacewalk/issues/25367
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!