Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check variable if not nil for flaky tests tagging #9805

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

ktsamis
Copy link
Contributor

@ktsamis ktsamis commented Feb 19, 2025

What does this PR change?

Check variable if not nil for flaky tests tagging. Not yet tested

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite

  • No tests: already covered

  • DONE

Links

Issue(s): Fixes: https://github.com/SUSE/spacewalk/issues/26477
Port(s):

5.0: https://github.com/SUSE/spacewalk/pull/26592
4.3: https://github.com/SUSE/spacewalk/pull/26593

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

Copy link
Contributor

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕

You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/9805/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/9805/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

Copy link
Member

@srbarrios srbarrios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might hide an issue with that change.
Instead, we need to understand why we can't get this field anymore.
Probably an API breakingchange from GH.

@ktsamis
Copy link
Contributor Author

ktsamis commented Feb 24, 2025

We might hide an issue with that change. Instead, we need to understand why we can't get this field anymore. Probably an API breakingchange from GH.

Yes agreed, I did this quickly without seeing why the variable was empty. I will take a look soon on this

@ktsamis
Copy link
Contributor Author

ktsamis commented Feb 24, 2025

The status on this card was not set, it was "No Status" and it was on a separate column named like that, as soon as it was moved the column disappeared. Testing to see if I can reproduce it moving cards in the board because I see the workflows should set this already to "New"

@ktsamis
Copy link
Contributor Author

ktsamis commented Feb 24, 2025

Pretty sure I can reproduce it here https://github.com/SUSE/spacewalk/issues/26526 by going to the issue and removing the status from the "New" which is added automatically. I think setting like this the variable to ignore empty status is ok because it's a manual case and should not happen. When we see issues like this we should set the status but not have it cause tracebacks in the CI.

@ktsamis ktsamis requested a review from srbarrios February 24, 2025 21:06
@raulillo82 raulillo82 merged commit e1401cc into uyuni-project:master Mar 4, 2025
17 checks passed
@ktsamis ktsamis deleted the flaky_tagging branch March 4, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants