-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt package queries for modular repositories #8525
Adapt package queries for modular repositories #8525
Conversation
👋 Hello! Thanks for contributing to our project. If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code. Reference tests: KNOWN ISSUES Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience. For more tips on troubleshooting, see the troubleshooting guide. Happy hacking! |
07fd58e
to
2699353
Compare
2699353
to
e679b81
Compare
Suggested tests to cover this Pull Request
|
9f6ecc0
to
3af0035
Compare
3af0035
to
9b99a31
Compare
9b99a31
to
059b051
Compare
c5a0169
to
960476d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check unique index and NULL value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you forgot the schema migration when changing the unique constraint
...er-schema-5.0.6-to-susemanager-schema-5.0.7/520-change-channel-newest-package-table-view.sql
Outdated
Show resolved
Hide resolved
cddea65
to
30b4d65
Compare
30b4d65
to
499ec3f
Compare
499ec3f
to
d24c6ae
Compare
What does this PR change?
It adapts package queries to filter out modular packages that are part of disabled modules in the server.
GUI diff
No difference.
Documentation
No documentation needed: only internal and user invisible changes
DONE
Test coverage
No tests: already covered
DONE
Links
Fixes: https://github.com/SUSE/spacewalk/issues/23785
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!