Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in 'Deploy Files' page #8284

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

NamelessOne91
Copy link
Contributor

@NamelessOne91 NamelessOne91 commented Feb 8, 2024

What does this PR change?

Fix a typo appearing in the "Deploy Files" page when trying to deploy configuration files.

Comfirm -> Confirm

image

GUI diff

After: Same with "Confirm" in the displayed text

  • DONE

Documentation

  • DONE

Test coverage

  • No tests: minor change in UI

  • DONE

Links

Port(s): Manager 4.3 https://github.com/SUSE/spacewalk/pull/23660

  • DONE

Changelogs

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Copy link
Contributor

github-actions bot commented Feb 8, 2024

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/8284/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/8284/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

Copy link
Contributor

github-actions bot commented Feb 8, 2024

Suggested tests to cover this Pull Request
  • srv_menu

@NamelessOne91 NamelessOne91 marked this pull request as ready for review February 8, 2024 16:01
@NamelessOne91 NamelessOne91 requested a review from a team as a code owner February 8, 2024 16:01
@NamelessOne91 NamelessOne91 self-assigned this Feb 8, 2024
@Bischoff Bischoff self-requested a review February 9, 2024 14:19
@NamelessOne91 NamelessOne91 merged commit 83b0eb9 into uyuni-project:master Feb 20, 2024
30 checks passed
@NamelessOne91 NamelessOne91 deleted the deploy_files_typo branch February 22, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants