Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Revert py2.7 incompatible formatting #8229

Merged
merged 1 commit into from
Jan 29, 2024
Merged

fix: Revert py2.7 incompatible formatting #8229

merged 1 commit into from
Jan 29, 2024

Conversation

m-czernek
Copy link
Contributor

What does this PR change?

This PR reverts linting and formatting, which turns out to be incompatible with py2.7. This is because we still support running the spacecmd code on py2.7.

@m-czernek m-czernek requested a review from a team as a code owner January 29, 2024 12:03
@m-czernek m-czernek requested a review from ycedres January 29, 2024 12:03
deneb-alpha
deneb-alpha approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@deneb-alpha deneb-alpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@raulillo82 raulillo82 merged commit 977ca44 into uyuni-project:master Jan 29, 2024
20 of 22 checks passed
@m-czernek m-czernek deleted the revert-spacecmd-dir branch February 8, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deneb-alpha deneb-alpha deneb-alpha approved these changes

@meaksh meaksh meaksh approved these changes

@ycedres ycedres Awaiting requested review from ycedres ycedres is a code owner automatically assigned from uyuni-project/python

Assignees
No one assigned
Labels
needs-translation python3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@m-czernek @deneb-alpha @meaksh @raulillo82