Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't change the /etc/motd at the end of the setup #8224

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

cbosdo
Copy link
Contributor

@cbosdo cbosdo commented Jan 26, 2024

What does this PR change?

In a container the /etc/motd file is not persisted and defined in the container image, avoid writing this file in the setup.

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests" (Test skipped, there are no changes to test)
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

Copy link
Contributor

@Bischoff Bischoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much Cédric, but it solves only part of the problem: the prompt will still be "uyuni-server" for a SUSE Manager server...

@cbosdo
Copy link
Contributor Author

cbosdo commented Jan 29, 2024

Thank you very much Cédric, but it solves only part of the problem: the prompt will still be "uyuni-server" for a SUSE Manager server...

No because in the container the /etc/motd is replaced with https://github.com/uyuni-project/uyuni/blob/master/containers/server-image/motd and if the setup doesn't overwrite it, it'll stay.

In a container the /etc/motd file is not persisted and defined in the
container image, avoid writing this file in the setup.
@cbosdo cbosdo merged commit fbe18b2 into uyuni-project:master Feb 1, 2024
29 of 30 checks passed
@cbosdo cbosdo deleted the motd-removal branch February 1, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants