-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
One shot action execution #8205
One shot action execution #8205
Conversation
Signed-off-by: Pascal Arlt <[email protected]>
👋 Hello! Thanks for contributing to our project. If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code. Reference tests: KNOWN ISSUES Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience. For more tips on troubleshooting, see the troubleshooting guide. Happy hacking! |
Suggested tests to cover this Pull Request
|
9b7898e
to
0be4803
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The frontend part looks very solid, what do you mean you don't leave me anything to pick at. Nice. 😄
java/code/src/com/suse/manager/webui/controllers/RecurringActionController.java
Outdated
Show resolved
Hide resolved
java/code/src/com/suse/manager/webui/utils/gson/RecurringActionScheduleJson.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Pascal Arlt <[email protected]>
0be4803
to
307cfe0
Compare
25e6df1
to
307cfe0
Compare
What does this PR change?
Add support for one shot action execution during create/edit of a recurring custom state schedule. If multiple systems are part of the entity a list that allows for selection of individual systems will be displayed.
GUI diff
After:
Documentation
No documentation needed: Small QoL change. Does not affect the functionality of the feature
DONE
Test coverage
No tests: small visual change.
DONE
Links
Issue(s): https://github.com/SUSE/spacewalk/issues/22484
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!