Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One shot action execution #8205

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

parlt91
Copy link
Contributor

@parlt91 parlt91 commented Jan 24, 2024

What does this PR change?

Add support for one shot action execution during create/edit of a recurring custom state schedule. If multiple systems are part of the entity a list that allows for selection of individual systems will be displayed.

GUI diff

After:

one-shot-button

one-shot-list

  • DONE

Documentation

  • No documentation needed: Small QoL change. Does not affect the functionality of the feature

  • DONE

Test coverage

  • No tests: small visual change.

  • DONE

Links

Issue(s): https://github.com/SUSE/spacewalk/issues/22484

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

Signed-off-by: Pascal Arlt <[email protected]>
@parlt91 parlt91 requested review from a team as code owners January 24, 2024 08:56
@parlt91 parlt91 requested a review from wweellddeerr January 24, 2024 08:56
Copy link
Contributor

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/8205/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/8205/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

Copy link
Contributor

Suggested tests to cover this Pull Request
  • min_salt_minions_page
  • min_ssh_tunnel
  • min_config_state_channel_subscriptions
  • min_config_state_channel_api
  • proxy_as_pod_basic_tests
  • allcli_config_channel
  • min_deblike_ssh
  • minssh_bootstrap_api
  • min_bootstrap_api
  • min_salt_mgrcompat_state
  • min_action_chain
  • minssh_move_from_and_to_proxy
  • min_salt_formulas_advanced
  • srv_group_union_intersection
  • allcli_system_group
  • srv_cobbler_profile
  • min_config_state_channel
  • min_recurring_action
  • min_activationkey
  • proxy_retail_pxeboot_and_mass_import
  • min_rhlike_ssh
  • srv_handle_config_channels_with_ISS_v2
  • min_bootstrap_reactivation
  • minssh_action_chain
  • min_salt_formulas
  • min_bootstrap_script
  • min_move_from_and_to_proxy
  • srv_user_configuration_salt_states
  • min_bootstrap_ssh_key
  • min_empty_system_profiles
  • srv_rename_hostname
  • srv_monitoring
  • allcli_sanity
  • proxy_branch_network
  • proxy_cobbler_pxeboot

@parlt91 parlt91 requested a review from Etheryte January 24, 2024 08:56
@parlt91 parlt91 force-pushed the one-shot-action-execution branch from 9b7898e to 0be4803 Compare January 24, 2024 09:01
Copy link
Member

@Etheryte Etheryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The frontend part looks very solid, what do you mean you don't leave me anything to pick at. Nice. 😄

@parlt91 parlt91 force-pushed the one-shot-action-execution branch from 0be4803 to 307cfe0 Compare January 25, 2024 13:57
@parlt91 parlt91 force-pushed the one-shot-action-execution branch 2 times, most recently from 25e6df1 to 307cfe0 Compare January 25, 2024 15:22
@parlt91 parlt91 merged commit 70d72b4 into uyuni-project:master Jan 25, 2024
48 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants