Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention the missing sync for Retail in Uyuni #8146

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

Bischoff
Copy link
Contributor

@Bischoff Bischoff commented Jan 11, 2024

What does this PR change?

This PR addresses the reposync for Retail in the Uyuni case.

According to Ondrej, the existing Uyuni channels contain all the Retail packages, so this PRs just adds two comments stating there is nothing to do.

Links

Ports:

  • 4.3: SUSE/spacewalk#23404

Changelogs

  • No changelog needed

Copy link
Contributor

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/8146/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/8146/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

@Bischoff Bischoff force-pushed the missing-sync-retail-uyuni branch from f852505 to 197af5e Compare January 11, 2024 16:24
@Bischoff Bischoff requested review from aaannz and nadvornik January 11, 2024 16:32
@aaannz
Copy link
Contributor

aaannz commented Jan 11, 2024

IIUC, this is just for uyuni, right? Then this is not needed. There are no special channels for retail under uyuni. Everything is in the uyuni repo.
Or are you testing SUMA RBS as a client to Uyuni? That seems like a strange scenario to me. Technically ok, but with RBS subscription you get SUMA as well, I think.

@Bischoff
Copy link
Contributor Author

IIUC, this is just for uyuni, right? Then this is not needed. There are no special channels for retail under uyuni. Everything is in the uyuni repo.

Yes, this is for Uyuni. So there is absolutely nothing special to sync when someone wants Retail in Uyuni ?

If that's the case, i'll just add a comment so that no one else starts wondering the same...

Or are you testing SUMA RBS as a client to Uyuni? That seems like a strange scenario to me. Technically ok, but with RBS subscription you get SUMA as well, I think.

No, I did not even imagine something so weird 😄 .

@Bischoff
Copy link
Contributor Author

I redid the PR to acknowledge there are no dedicated channels in this case.

@@ -755,6 +755,8 @@ Feature: Synchronize products in the products page of the Setup Wizard
And I wait until I see "SUSE Manager Retail Branch Server 4.3 x86_64" product has been added
And I wait until all synchronized channels for "suma-retail-branch-server-43" have finished

# There are no channels for Retail under Uyuni
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even surprising...

@Bischoff Bischoff force-pushed the missing-sync-retail-uyuni branch from 9672372 to d69a664 Compare January 12, 2024 08:57
@Bischoff Bischoff changed the title Add missing sync for Retail in Uyuni Mention the missing sync for Retail in Uyuni Jan 12, 2024
@Bischoff Bischoff force-pushed the missing-sync-retail-uyuni branch from d69a664 to 5a40967 Compare January 12, 2024 09:04
@raulillo82 raulillo82 merged commit 4170192 into uyuni-project:master Jan 12, 2024
15 checks passed
@Bischoff Bischoff deleted the missing-sync-retail-uyuni branch January 16, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants