Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QE: replace a JS call with UI interaction #8127

Merged

Conversation

NamelessOne91
Copy link
Contributor

@NamelessOne91 NamelessOne91 commented Jan 9, 2024

What does this PR change?

Closes https://github.com/SUSE/spacewalk/issues/14266

Replace the JS call to setScheduleTime() with actual UI interactions.

GUI diff

No difference

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • A step used in a Cucumber test was edited

  • DONE

Links

Issue(s): https://github.com/SUSE/spacewalk/issues/14266
Ports(s): Manager 4.3 https://github.com/SUSE/spacewalk/pull/23368

  • DONE

Changelogs

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

@NamelessOne91 NamelessOne91 requested a review from a team as a code owner January 9, 2024 16:08
@NamelessOne91 NamelessOne91 self-assigned this Jan 9, 2024
Copy link
Contributor

github-actions bot commented Jan 9, 2024

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/8127/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/8127/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

Copy link
Contributor

@maximenoel8 maximenoel8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good.
I can see in datepicker steps that our way of describing the actions are really different from navigation for example where we are using actions from commonlib.rb.

But for homogeneity we should probably keep doing that.

@Bischoff Bischoff requested a review from srbarrios January 18, 2024 10:57
@NamelessOne91 NamelessOne91 merged commit 28ee2af into uyuni-project:master Jan 19, 2024
9 checks passed
@NamelessOne91 NamelessOne91 deleted the schedule_action_from_UI branch February 9, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants