Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add channels to wait for #8116

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Add channels to wait for #8116

merged 1 commit into from
Jan 9, 2024

Conversation

Bischoff
Copy link
Contributor

@Bischoff Bischoff commented Jan 9, 2024 •
edited
Loading

What does this PR change?

Some steps to wait for reposync seem to be missing.

Piggyback: augment timeout from 2 hours to 2 hours and a half because of debian 11.

Links

Ports:

  • 4.3: SUSE/spacewalk#23364

Changelogs

  • No changelog needed

@Bischoff Bischoff requested a review from a team as a code owner January 9, 2024 09:32
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024 •
edited
Loading

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/8116/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/8116/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

srbarrios
srbarrios approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@srbarrios srbarrios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

srbarrios
srbarrios reviewed Jan 9, 2024
View reviewed changes
testsuite/features/build_validation/reposync/srv_sync_all_products.feature
@@ -226,11 +233,13 @@ Feature: Synchronize products in the products page of the Setup Wizard
When I click the Add Product button
And I wait until I see "Selected channels/products were scheduled successfully for syncing." text
And I wait until I see "SUSE Linux Enterprise Micro 5.1 x86_64" product has been added
And I wait until all synchronized channels for "suse-microos-5.1" have finished
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see suse-microos-5.1 defined in CHANNEL_TO_SYNCH_BY_OS_PRODUCT_VERSION

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's there

  'suse-microos-5.1' =>
    %w[

srbarrios
srbarrios reviewed Jan 9, 2024
View reviewed changes
testsuite/features/build_validation/reposync/srv_sync_all_products.feature
@@ -261,11 +270,13 @@ Feature: Synchronize products in the products page of the Setup Wizard
When I click the Add Product button
And I wait until I see "Selected channels/products were scheduled successfully for syncing." text
And I wait until I see "SUSE Linux Enterprise Micro 5.2 x86_64" product has been added
And I wait until all synchronized channels for "suse-microos-5.2" have finished
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see suse-microos-5.2 defined in CHANNEL_TO_SYNCH_BY_OS_PRODUCT_VERSION

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's there

  'suse-microos-5.2' =>
    %w[

srbarrios
srbarrios reviewed Jan 9, 2024
View reviewed changes
testsuite/features/build_validation/reposync/srv_sync_all_products.feature
@@ -296,11 +307,13 @@ Feature: Synchronize products in the products page of the Setup Wizard
When I click the Add Product button
And I wait until I see "Selected channels/products were scheduled successfully for syncing." text
And I wait until I see "SUSE Linux Enterprise Micro 5.3 x86_64" product has been added
And I wait until all synchronized channels for "sle-micro-5.3" have finished
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see suse-microos-5.3 defined in CHANNEL_TO_SYNCH_BY_OS_PRODUCT_VERSION

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because it's called otherwise:

  'sle-micro-5.3' =>
    %w[

srbarrios
srbarrios reviewed Jan 9, 2024
View reviewed changes
testsuite/features/build_validation/reposync/srv_sync_all_products.feature Outdated
@@ -433,6 +446,7 @@ Feature: Synchronize products in the products page of the Setup Wizard
@sle15sp5s390_minion
Scenario: Add SUSE Linux Enterprise Server 15 SP5 for s390x Uyuni Client tools
When I use spacewalk-common-channel to add channel "sles15-sp5-devel-uyuni-client" with arch "s390x"
And I wait until all synchronized channels for "sles1-sp5-s390x" have finished
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
And I wait until all synchronized channels for "sles1-sp5-s390x" have finished
And I wait until the channel "sles15-sp5-devel-uyuni-client" has been synced

But.... I'm not sure how that will work with multiple architectures.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code seems to be using:

dumpsolv /var/cache/rhn/repodata/#{channel}/solv
zcat /var/cache/rhn/repodata/#{channel}/*primary.xml.gz

That looks like it's architecture-independent...

@Bischoff Bischoff force-pushed the forgotten-waits branch 4 times, most recently from 96b57d3 to d1e5856 Compare January 9, 2024 14:41
@Bischoff Bischoff merged commit 1f3f44f into uyuni-project:master Jan 9, 2024
9 checks passed
@Bischoff Bischoff deleted the forgotten-waits branch January 10, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srbarrios srbarrios srbarrios approved these changes

@NamelessOne91 NamelessOne91 NamelessOne91 approved these changes

Assignees
No one assigned
Labels
build-validation-features ruby_rubocop test-framework testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bischoff @srbarrios @NamelessOne91