Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use https to access the API in spacewalk-common-channels and mgr-sync #7879

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

cbosdo
Copy link
Contributor

@cbosdo cbosdo commented Nov 15, 2023

What does this PR change?

In some cases the http port seems not available for the XML-RPC API. Use http://localhost:80 by default for those tools and https when using the server's FQDN.

Using localhost helps reducing the possible hairpins when running in a container environment.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • No tests: tools defaults, partly covered by e2e tests

  • DONE

Links

Fixes #5565

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

@cbosdo cbosdo requested a review from a team as a code owner November 15, 2023 13:53
@cbosdo cbosdo requested review from vzhestkov and removed request for a team November 15, 2023 13:53
Copy link
Contributor

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Jan 15, 2024
Copy link
Contributor

@vzhestkov vzhestkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general the change is good for me, but just one nitpicky suggestion inline just to make the code more readable.

In some cases the http port seems not available for the XML-RPC API. Use
http://localhost:80 by default for those tools and https when using the
server's FQDN.

Using localhost help reducing the possible hairpins when running in a
container environment.
@cbosdo cbosdo removed the Stale label Jan 15, 2024
@cbosdo cbosdo merged commit 5ba17e7 into uyuni-project:master Jan 22, 2024
18 checks passed
@cbosdo cbosdo deleted the https-tools-fix branch January 22, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refreshing Repositories/Channels Fails
3 participants