Dedicated container for database #482
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadvornik
force-pushed
the
postgres
branch
2 times, most recently
from
fbf2549 to
10155ce
Compare
aaannz
reviewed
Jan 22, 2025
rjmateus
reviewed
Jan 31, 2025
mgradm/shared/pgsql/pgsql.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| err = podman.RunContainer("uyuni-db-migrate", pgsqlImage, utils.PgsqlRequiredVolumeMounts, []string{}, |
There was a problem hiding this comment.
The updade command also deals with major version upgrade? I think that at version 5.0 Michele prepared the upgrade process with the upgrade container to allow major upgrades where the database version would. Is this taken into consideration?
cbosdo
reviewed
Feb 3, 2025
|
@nadvornik what's holding us here? will we be able to get this in for beta 1? |
I'm working on getting this PR into shape. |
cbosdo
force-pushed
the
postgres
branch
2 times, most recently
from
2ac90ed to
acc6f01
Compare
aaannz
approved these changes
Mar 4, 2025
cbosdo
force-pushed
the
postgres
branch
2 times, most recently
from
f46f7fa to
329d086
Compare
List of improvements: - Use Secrets for SSL and DB credentials - Add DB container support to uninstall, start, stop, restart and status - Cleanup the setup from the now unneeded parameters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Current state:
Works with the image from uyuni-project/uyuni#9469
mgradm install podman --pgsql-image <image> --pgsql-tag <tag>Uses workarounds for the issues discussed in https://github.com/SUSE/spacewalk/issues/25363
Missing kubernetes.
Test coverage
No tests: add explanation
No tests: already covered
Unit tests were added
DONE
Links
Issue(s): #
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test(see below)Before you merge
Check How to branch and merge properly!