Split out salt-master and salt-api containers #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzhestkov
force-pushed
the
split-salt-master-and-salt-api
branch
from
d3c83ae to
a114bb1
Compare
rjmateus
reviewed
May 30, 2025
| Make `salt-master` service abailable for the minions with ports `4505` and `4506` by publishing these ports from `uyuni-salt-master` container. | ||
| The following storage volumes need to be mapped to the `uyuni-salt-master` container: | ||
|
|
||
| | Volume | Comment | |
There was a problem hiding this comment.
We will need to research and document which volumes need to be shared with the big container. Tomcat writes the configuration channels to disk in the salt folder. We need to share those locations as writable in the big container, and probably read only on salt-master
There was a problem hiding this comment.
Oh, seems srv-susemanager:/srv/susemanager is missing in the list, but about this one I'm wondering why do we have a separate sls files per system, maybe it will be better to refactor it slightly to use common states, but using jinja to fill corresponding sections with pillar data? That way we can avoid one extra common issue when the file is missing due to faulty registration.
m-czernek
reviewed
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered