Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around initrd issue in sle11sp4 #888

Merged
merged 1 commit into from
May 25, 2021

Conversation

Bischoff
Copy link
Contributor

@Bischoff Bischoff commented May 21, 2021

What does this PR change?

This PR makes sure SLES 11 SP4 uses same version for kernel and kernel modules after a reboot.

A better solution would be to generate correct images. For more details, see #887.

@Bischoff Bischoff requested review from moio, srbarrios and rjmateus May 21, 2021 16:07
@moio
Copy link
Contributor

moio commented May 24, 2021

Are we sure the grub menu is incorrect right after the image has been created?

Sources: https://build.suse.de/package/view_file/Devel:Galaxy:Terraform:Images/sles11sp4/sles11sp4.kiwi?expand=1

IOW, I wonder whether the image is actually wrong or if we are updating the kernel for whatever reason, and it's the update that's gone wrong.

@srbarrios
Copy link
Member

srbarrios commented May 24, 2021

If we need to hack something in the current sles11sp4 custom image, I would do it as earlier as possible, at the cloud-init stage.
So here: https://github.com/uyuni-project/sumaform/blob/master/backend_modules/libvirt/host/user_data.yaml

@Bischoff
Copy link
Contributor Author

Bischoff commented May 25, 2021

Are we sure the grub menu is incorrect right after the image has been created?

Yes, I loop-mounted the freshly downloaded qcow2, and the problem is already there.

Sources: https://build.suse.de/package/view_file/Devel:Galaxy:Terraform:Images/sles11sp4/sles11sp4.kiwi?expand=1

Thanks, that helps.

IOW, I wonder whether the image is actually wrong or if we are updating the kernel for whatever reason, and it's the update that's gone wrong.

Nope, the image is already wrong.

@Bischoff
Copy link
Contributor Author

If we need to hack something in the current sles11sp4 custom image, I would do it as earlier as possible, at the cloud-init stage.
So here: https://github.com/uyuni-project/sumaform/blob/master/backend_modules/libvirt/host/user_data.yaml

Why not, but an even better solution would be to directly fix image creation.

The problem is, I'd like to test GMC now with a SLES 11 SP4 that survives a reboot. So I would suggest to apply this PR and remove it once we have something better.

@Bischoff
Copy link
Contributor Author

Bischoff commented May 25, 2021

I failed trying to modify directly the image, ibs tool kills my workstation (freezing). I will apply this with big HACK signs.

@Bischoff Bischoff merged commit ddac88b into uyuni-project:master May 25, 2021
@Bischoff
Copy link
Contributor Author

Reverted, I get a different image in CI than in my local tests...

@srbarrios
Copy link
Member

Is our mirror updated?

@Bischoff
Copy link
Contributor Author

Is our mirror updated?

Good question.

I will give it a go again after next BV deployment. It could have been the mirror, it could be sumaform does differently when using the testsuite module or not, or it could have been me missing some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants