Skip to content

Add 5.1 to CI #1846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025
Merged

Add 5.1 to CI #1846

merged 1 commit into from
May 28, 2025

Conversation

Bischoff
Copy link
Contributor

@Bischoff Bischoff commented May 27, 2025

What does this PR change?

This PR adds 5.1 to CI

Notes:

  • the Ubuntu 24.04 workarounds are not ready to be removed yet
  • the code for SL Micro 6.1 containerized server and proxy was already done by @maximenoel8 in backend_modules/libvirt/host/combustion
  • this PR uses by default SL Micro 6.1 for images. We have a separate issue for allowing SLE 15 SP7 as default image.
    That being said, SLE 15 SP7 is supported by this PR, you only have to force the image.
    For the moment, SLE 15 SP7 as base OS is tested in dedicated "alternate" BV test suite.
  • this PR moves back some code from cloud-init to salt/repos
  • this PR also finally removes 4.3-beta

This is the second attempt. First attempt is here: #1842.

@Bischoff Bischoff requested a review from a team as a code owner May 27, 2025 15:29
@srbarrios
Copy link
Member

SLE 15 SP7 as base OS is tested in dedicated "alternate" BV test suite.

@Bischoff Keep in mind we only have that alternative BV for 5.0, not for 5.1

@@ -5,11 +5,11 @@ variable "testsuite-branch" {
"4.3-pr" = "Manager-4.3"
"4.3-VM-released"= "Manager-4.3"
"4.3-VM-nightly" = "Manager-4.3"
"4.3-beta" = "master"
"4.3-beta" = "Manager-4.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to keep 4.3-beta ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, removed.

# - gpgkey: http://{{ grains.get("mirror") | default("dist.nue.suse.com/ibs", true) }}/Devel:/Galaxy:/Manager:/5.0/images/repo/SUSE-Manager-Proxy-5.0-POOL-x86_64-Media1/repodata/repomd.xml.key
{% endif %}

{% elif grains['osfullname'] == 'SLES' %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have it done the other around.
if product version
if slemicro
endif
if sles
endif
endif

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But fine with me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Er, isn't it what we have ?

if product version
if slemicro
elif sles
endif
endif

just endif if => elif

@Bischoff
Copy link
Contributor Author

Bischoff commented May 28, 2025

SLE 15 SP7 as base OS is tested in dedicated "alternate" BV test suite.

@Bischoff Keep in mind we only have that alternative BV for 5.0, not for 5.1

Er, right. SLE 15 SP6 in that case.

It should be relatively straightforward to transpose it for 5.1 and SLE 15 SP7 though.

@Bischoff Bischoff merged commit 2569d99 into uyuni-project:master May 28, 2025
2 checks passed
@Bischoff
Copy link
Contributor Author

Tests passed, merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants