-
Notifications
You must be signed in to change notification settings - Fork 74
Add 5.1 to CI #1846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 5.1 to CI #1846
Conversation
@Bischoff Keep in mind we only have that alternative BV for 5.0, not for 5.1 |
modules/controller/main.tf
Outdated
@@ -5,11 +5,11 @@ variable "testsuite-branch" { | |||
"4.3-pr" = "Manager-4.3" | |||
"4.3-VM-released"= "Manager-4.3" | |||
"4.3-VM-nightly" = "Manager-4.3" | |||
"4.3-beta" = "master" | |||
"4.3-beta" = "Manager-4.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to keep 4.3-beta ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, removed.
# - gpgkey: http://{{ grains.get("mirror") | default("dist.nue.suse.com/ibs", true) }}/Devel:/Galaxy:/Manager:/5.0/images/repo/SUSE-Manager-Proxy-5.0-POOL-x86_64-Media1/repodata/repomd.xml.key | ||
{% endif %} | ||
|
||
{% elif grains['osfullname'] == 'SLES' %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have it done the other around.
if product version
if slemicro
endif
if sles
endif
endif
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But fine with me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Er, isn't it what we have ?
if product version
if slemicro
elif sles
endif
endif
just endif if => elif
Er, right. SLE 15 SP6 in that case. It should be relatively straightforward to transpose it for 5.1 and SLE 15 SP7 though. |
Tests passed, merged. |
What does this PR change?
This PR adds 5.1 to CI
Notes:
backend_modules/libvirt/host/combustion
That being said, SLE 15 SP7 is supported by this PR, you only have to force the image.
For the moment, SLE 15 SP7 as base OS is tested in dedicated "alternate" BV test suite.
salt/repos
4.3-beta
This is the second attempt. First attempt is here: #1842.