Add new controller variable to enable / disable the catch timeout mes… #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sage we have during BV
srbarrios
reviewed
Jan 18, 2024
modules/controller/variables.tf
Outdated
| @@ -762,6 +762,11 @@ variable "no_mirror" { | |||
| default = false | |||
| } | |||
|
|
|||
| variable "catch_timeout_message" { | |||
| description = "Specify to controller, enable the mechanism to catch timeout message we have during BV" | |||
There was a problem hiding this comment.
I would avoid mentioning anything in regard BV, as sumaform should not know about this concept.
Maybe something like:
"Enable the mechanism to catch the timeout message shown by a server overloaded"
srbarrios
approved these changes
Jan 18, 2024
NamelessOne91
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR
During build validation, we have server instability when bootstrapping the clients in parallel but also when running the smoke tests in parallel.
To manage this situation and avoid having to run those stages manually, we added a mechanism in the testsuite to catch those timeouts and reload the page when possible.
This mechanism is now optional and is disable by default
This PR add the possibility to enable the catch timeout mechanism during CI deployment.
It creates a new variable used in the controller bashrc to enable the catch timeout mechanism.