Reboot on salt key timeout (bsc#1237495) #174
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzhestkov
approved these changes
Mar 3, 2025
There was a problem hiding this comment.
The only nitpicky comment I have: let's maybe change the name of SALT_TIMEOUT to something more self-explanatory? There are a lot of internal timeout parameters for salt and it could be not that clear from the first glance what this one refers to, and finally it leads to the finding that it refers to none of them.
|
We can't change We can only deprecate it and introduce better value, for example |
aaannz
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Salt minion sometimes fails to create minion key. This PR adds a reboot after timeout to prevent infinite waiting.