Added rfc for removing vulkan SDK. #655
Conversation
rfc-0004.md
Outdated
| --- | ||
| rfc: 4 | ||
| title: Removing support for Vulkan | ||
| author: Colin Davidson <[email protected]> | ||
| status: draft | ||
| --- | ||
|
|
||
| ``` text |
There was a problem hiding this comment.
| --- | |
| rfc: 4 | |
| title: Removing support for Vulkan | |
| author: Colin Davidson <[email protected]> | |
| status: draft | |
| --- | |
| ``` text |
The idea was that https://uxlfoundation.github.io/oneapi-construction-kit/rfc-0002.html showed what should be used as a template for new files, but you have taken the whole rfc-0002.md as the template for new files. This may have been unclear in the process, thoughts welcome on how to make this clearer.
There was a problem hiding this comment.
I'm a little unclear on why we should remove these lines? They seemed to give useful information.
There was a problem hiding this comment.
For the first six lines, this is useful but it is duplicated, this is already present in the immediately following bit. For the eighth line, it means the whole RFC is treated as plain text rather than Markdown.
There was a problem hiding this comment.
Yes, of course you are quite right, I should have noticed the intention. Personally I prefer a template I can just copy as is.
There was a problem hiding this comment.
I get that. The background here is that the inspiration for this, https://peps.python.org/pep-0012/, contains a lot more than just the template, it also contains details on how to write RST. That documentation would not apply to us since we use Markdown, so I took it out for us, and the template is all that is left. Ideally, in the future, we would add some Markdown documentation there.
coldav
force-pushed
the
colin/add_vulkan_rfc
branch
from
635580b to
21b3fd9
Compare
rfc-0004.md
Outdated
| @@ -0,0 +1,85 @@ | |||
| --- | |||
| rfc: 0004 | |||
There was a problem hiding this comment.
| rfc: 0004 | |
| rfc: 3 |
No need for the leading 0s outside of the file name, including them here would cause them to show up on the index page, and the first available RFC number is 3. (This should of course also be accompanied by a rename of the file.)
There was a problem hiding this comment.
sure, renamed as well.
coldav
force-pushed
the
colin/add_vulkan_rfc
branch
from
21b3fd9 to
94c69a9
Compare
Overview
Added rfc for removing vulkan SDK.
Reason for change
See rfc
Description of change
See rfc