[cuBLAS][rocBLAS] Fix uninstantiated template static asserts for older compilers #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r compilers CWG2518 allowing static_assert(false) in uninstantiated template is a C++23 behaviour that happens to work regardless of -std flag in recent compilers (clang >= 17) including DPC++. However, AdaptiveCpp is based on an older clang version and does not support that. Force the static assert evaluation to be pushed after template evaluations by using type T inside the expression. This works in all supported compilers. Also add a message in the assert to clarify why it's there.
|
/intelci: run |
Rbiessy
approved these changes
Mar 25, 2025
|
@sknepper since you commented on the PR do you want to give the second approval? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CWG2518 allowing
static_assert(false)in uninstantiated template is a C++23 behaviour that happens to work regardless of-stdflag in recent compilers (clang >= 17) including DPC++. However, AdaptiveCpp is based on an older clang version and does not support that.Force the static assert evaluation to be pushed after template evaluations by using type T inside the expression. This works in all supported compilers. Also add a message in the assert to clarify why it's there.
Credits to @DuncanMcBain for the solution.
Fixes #617