Changed all references from hipSYCL to AdaptiveCpp #543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rbiessy
reviewed
Jul 24, 2024
Rbiessy
approved these changes
Jul 25, 2024
al42and
reviewed
Aug 8, 2024
Contributor
al42and
left a comment
al42and
left a comment
There was a problem hiding this comment.
A few minor observations.
Also, since AdaptiveCpp_enqueue_custom_operation is now used, the minimal AdaptiveCpp version in README should be updated to 24.06.
al42and
reviewed
Aug 8, 2024
Co-authored-by: Andrey Alekseenko <[email protected]>
Co-authored-by: Andrey Alekseenko <[email protected]>
Co-authored-by: Andrey Alekseenko <[email protected]>
andrewtbarker
approved these changes
Aug 16, 2024
Contributor
andrewtbarker
left a comment
andrewtbarker
left a comment
There was a problem hiding this comment.
BLAS-related changes look good to me!
Contributor
|
Can you make sure you go over the changes from #546 which added more occurrences to rename? |
3 tasks
1 task
Contributor
|
This work has been moved to #699 |
Contributor
|
Closing in favor of #699 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All references to hipSYCL have been changed to AdaptiveCpp. Most of the targets failed to compile because they are trying to compile using the -fsycl flag. The only target that compiles is the rng target for CPU; on GPU, it also generates the -fsycl error.