Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edits and comments on draft f1ecec5 #13

Closed
wants to merge 2 commits into from
Closed

Conversation

jspaaks
Copy link

@jspaaks jspaaks commented May 28, 2024

Hey folks! Thanks for the great work so far. As I was going through the document, I realized I was perhaps a bit too early but I decided to send you my comments and edits anyway in hopes they would still be helpful. Feel free to accept / decline / edit as you see fit.

I have used HTML comments <!-- and --> to make comments in the source, so reviewers can use their machine-local tooling if they want. Note that these do end up in the rendered document, although browsers know not to show them.

Best regards,
Jurriaan

Copy link

welcome bot commented May 28, 2024

Thanks for opening this pull request! Please don't forget to add your information to _metadata.yml.

@arokem
Copy link
Contributor

arokem commented Jun 5, 2024

Hi @jspaaks : thanks for your contributions and apologies for the slowness. Would you mind adding your author metadata in the _metadata.yml file?

…flicts in 01-introduction.qmd and 02-challenges.qmd
@jspaaks
Copy link
Author

jspaaks commented Aug 27, 2024

Hi,

Thanks all for your work on this document. I just resolved conflicts after some time away from it (apologies for the delay), which left nothing to merge :) so I'll just close this PR.

As to the request above, it's good like it is now AFAIC.

@jspaaks jspaaks closed this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants