grep: rewind seekable stdin when -m stops the search early - #101
Merged
Conversation
Merging this PR will not alter performance
Comparing 
Footnotes
|
|
GNU grep testsuite comparison: |
Contributor
Author
|
trivial, auto merge for the next release |
lhecker
reviewed
Aug 10, 2026
Comment on lines
+120
to
+126
| // `-m` stops mid-input, but we have read further than the last selected | ||
| // line. Rewind so whoever reads standard input next sees the rest of it, | ||
| // as GNU does. A pipe cannot seek; there is nothing to hand back then. | ||
| if !self.session_can_match() | ||
| && let Ok(start) = start_offset | ||
| { | ||
| let _ = stdin.seek(SeekFrom::Start(start + self.session_last_match_end)); |
Collaborator
There was a problem hiding this comment.
How does this work if stdin cannot seek?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.