grep: reject misspelled character classes like [:space:]

[sylvestre]

No description provided.

[codspeed-hq]

Merging this PR will not alter performance

✅ 10 untouched benchmarks
⏩ 17 skipped benchmarks¹

---

_{Comparing sylvestre:grep-char-class-syntax (5aea8c3) with main (54a846c)}

Footnotes

1. 17 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[github-actions]

GNU grep testsuite comparison:

Test results comparison:
  Current:   TOTAL: 128 / PASSED: 76 / FAILED: 31 / SKIPPED: 21
  Reference: TOTAL: 128 / PASSED: 75 / FAILED: 32 / SKIPPED: 21

Changes from main branch:
  TOTAL: +0
  PASSED: +1
  FAILED: -1

Test improvements (1):
  + warn-char-classes

[github-actions]

GNU grep testsuite comparison:

Test results comparison:
  Current:   TOTAL: 128 / PASSED: 77 / FAILED: 30 / SKIPPED: 21
  Reference: TOTAL: 128 / PASSED: 76 / FAILED: 31 / SKIPPED: 21

Changes from main branch:
  TOTAL: +0
  PASSED: +1
  FAILED: -1

Test improvements (1):
  + warn-char-classes

[lhecker]

Why not disable ONIG_SYN_OP_POSIX_BRACKET instead? From the oniguruma documentation it sounds like the same thing:
https://github.com/kkos/oniguruma/blob/master/doc/SYNTAX.md#24-onig_syn_op_posix_bracket-enable-posix-xxxx

[lhecker]

Ah I see that controls both [:foo:] and [[:foo:]]. 😢