Skip to content

simplify assertions - #13756

Open
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:assert
Open

simplify assertions#13756
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:assert

Conversation

@oech3

@oech3 oech3 commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@codspeed-hq

codspeed-hq Bot commented Aug 5, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 8.76%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 3 regressed benchmarks
✅ 344 untouched benchmarks
⏩ 46 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation df_with_path 571.4 µs 699.6 µs -18.32%
Simulation cksum_multiple_files 60.6 ms 63 ms -3.8%
Simulation du_max_depth_balanced_tree[(6, 4, 10)] 59.8 ms 61.9 ms -3.35%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing oech3:assert (8b0bc17) with main (21d4e96)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@xtqqczze

xtqqczze commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

I'd prefer to avoid the unwrap by using something like assert_matches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants