Skip to content

comm /etc/pacman.conf /dev/null 2>/dev/full does not abort #10746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisDryden merged 1 commit into from
Feb 6, 2026
+4 −3
Merged

comm /etc/pacman.conf /dev/null 2>/dev/full does not abort #10746

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/uu/comm/src/comm.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
use std::cmp::Ordering;
use std::ffi::OsString;
use std::fs::{File, metadata};
use std::io::{self, BufRead, BufReader, BufWriter, Read, StdinLock, Write, stdin};
use std::io::{self, BufRead, BufReader, BufWriter, Read, StdinLock, Write, stderr, stdin};
use std::path::Path;
use uucore::display::Quotable;
use uucore::error::{FromIo, UResult, USimpleError};
Expand Down Expand Up @@ -114,7 +114,8 @@ impl OrderChecker {

let is_ordered = *current_line >= *self.last_line;
if !is_ordered && !self.has_error {
eprintln!(
let _ = writeln!(
stderr(),
"{}",
translate!("comm-error-file-not-sorted", "file_num" => self.file_num.as_str())
);
Expand Down Expand Up @@ -314,7 +315,7 @@ fn comm(
if should_check_order && (checker1.has_error || checker2.has_error) {
// Print the input error message once at the end
if input_error {
eprintln!("{}", translate!("comm-error-input-not-sorted"));
let _ = writeln!(stderr(), "{}", translate!("comm-error-input-not-sorted"));
}
Err(USimpleError::new(1, ""))
} else {
Expand Down
Loading