Improve Custom Callables and add SignalConnector #803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CedNaru
force-pushed
the
feautre/SignalConnector
branch
8 times, most recently
from
4a8dbc5 to
9945b0c
Compare
CedNaru
force-pushed
the
feautre/SignalConnector
branch
from
9945b0c to
9e77fb8
Compare
CedNaru
requested review from
chippmann and
piiertho
and removed request for
chippmann
CedNaru
force-pushed
the
feautre/SignalConnector
branch
from
4e6fd61 to
0e92e0a
Compare
chippmann
approved these changes
May 3, 2025
| * @return The loaded resource, or null if there was an error. | ||
| */ | ||
| public suspend inline fun ResourceLoader.awaitLoad( | ||
| path: String, | ||
| typeHint: String = "", | ||
| useSubThreads: Boolean = false, | ||
| cacheMode: CacheMode = ResourceLoader.CacheMode.REUSE, | ||
| crossinline onProgress: (RealT) -> Unit = {}, |
There was a problem hiding this comment.
I'd love for this to make a return at some point :-) Just a note not really related to this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement #765
First of a series of 3 PRs aiming at improving the Signal and Callable.
This one only focus on improving the Callable interface and fixing memory issues with CustomCallable.
For now, I disabled Java. I will remake it in the next PRs.
Don't worry, I'm targeting a working branch, not master.